netdev - Re: [ethtool PATCH] ethtool: Can't parse ints with stroul()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9929d2390912231358o23ceb94qe3480723a60d44ec@mail.gmail.com>
Date:	Wed, 23 Dec 2009 13:58:16 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, gospo@...hat.com,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
Subject: Re: [ethtool PATCH] ethtool: Can't parse ints with stroul()

On Wed, Dec 23, 2009 at 13:52, Jeff Garzik <jeff@...zik.org> wrote:
> On 12/09/2009 08:12 PM, Jeff Kirsher wrote:
>>
>> On Tue, Dec 8, 2009 at 09:32, Jeff Kirsher<jeffrey.t.kirsher@...el.com>
>>  wrote:
>>>
>>> From: PJ Waskiewicz<peter.p.waskiewicz.jr@...el.com>
>>>
>>> A recent change to how int's were being parsed from the command
>>> line had them being read in with an unsigned int string operator.
>>> This didn't allow signed numbers from being read in correctly.
>>> This patch adds a get_uint() routine, and fixes the get_int()
>>> routine to read in signed values.
>>>
>>> Signed-off-by: Peter P Waskiewicz Jr<peter.p.waskiewicz.jr@...el.com>
>>> Signed-off-by: Jeff Kirsher<jeffrey.t.kirsher@...el.com>
>>> ---
>>>
>>
>> Jeff G. - hold off on this patch.  We have a version 2 in the works,
>> because we found if the sign bit was set on a uint, this would fail
>> parsing.
>
> Was version 2 ever posted?  I never saw it...
>
>        Jeff
>

Not yet, version 2 of the patch is in test right now.  I should have
it sent out either later tonight or tomorrow.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html