netdev - Re: [RFC PATCH] gianfar: update txq->trans_start rather than dev->trans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091225.184503.28832017.davem@davemloft.net>
Date:	Fri, 25 Dec 2009 18:45:03 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	Sandeep.Kumar@...escale.com
Cc:	netdev@...r.kernel.org, avorontsov@...mvista.com
Subject: Re: [RFC PATCH] gianfar: update txq->trans_start rather than
 dev->trans_start

From: Sandeep Gopalpet <Sandeep.Kumar@...escale.com>
Date: Wed, 16 Dec 2009 19:34:41 +0530

> Signed-off-by: Sandeep Gopalpet <Sandeep.Kumar@...escale.com>
> ---
> 
>  *. Please let me know if updating txq->trans_start in gfar_start is
>     alright, although updating txq->trans_start in gfar_start_xmit( )
>     should be done.

See commit 08baf561083bc27a953aa087dd8a664bb2b88e8e, you don't have to
update *->trans_start at all, the generic code will do it for you.

For example, this is why you won't be able to find any trans_start
references in drivers such as ixgbe
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html