netdev - Compilation issues using netlink.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B37FCB3.9000800@linuxfromscratch.org>
Date:	Mon, 28 Dec 2009 00:32:51 +0000
From:	Matthew Burgess <matthew@...uxfromscratch.org>
To:	netdev@...r.kernel.org
CC:	davem@...emloft.net, ben@...adent.org.uk,
	linux-kernel@...r.kernel.org
Subject: Compilation issues using netlink.h

Hi,

The test case below simplifies a failure I see when trying to compile 
strace using kernel headers from Linux-2.6.32.2:

#include <linux/netlink.h>
struct sockaddr_nl nl;
int main() {
   return 0;
}

$ gcc -o test test.c
In file included from test.c:1:
/usr/include/linux/netlink.h:34: error: expected 
specifier-qualifier-list before 'sa_family_t'

The comment in netlink.h suggests that 'sa_family_t' is expected to be 
found in linux/socket.h, but since commit 9c501935a3 ("net: Support 
inclusion of <linux/socket.h> before <sys/socket.h>") that appears to 
not be true anymore, it's now in sys/socket.h.  Sure enough, if I change 
the include in netlink.h to pull in sys/socket.h instead of 
linux/socket.h, that enables the test case (and strace) to compile 
again, but I wasn't sure if it was really the right thing to do.

Thanks,

Matt.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html