netdev - Re: [PATCH] sky2: Lock transmit queue while disabling device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <4B3CCA17.5020707@majjas.com>
Date:	Thu, 31 Dec 2009 10:58:15 -0500
From:	Michael Breuer <mbreuer@...jas.com>
To:	Mike McCormack <mikem@...g3k.org>
Cc:	Stephen Hemminger <shemminger@...tta.com>, netdev@...r.kernel.org,
	flyboy@...il.com, dhazelton@...er.net
Subject: Re: [PATCH] sky2: Lock transmit queue while disabling device

This doesn't solve the issue on my system. Just ran a test - same 
errors. I don't think that the under-load errors I'm seeing involve 
sky2_detatch. I'm thinking it's related to the dhcp AF_INTERNET fix that 
solved the lockup under load - that something outside of sky2 is 
corrupting an skb.
On 12/31/2009 5:55 AM, Mike McCormack wrote:
> netif_device_detach() does not take the tx_lock, so it's
>   possible that a call to sky2_xmit_frame is still in
>   progress after netif_device_detach() is complete.
>
> Take netif_tx_lock() to make sure all transmits have
>   stopped while we're disabling the devices and that
>   no other CPU is still transmitting a frame after
>   we've disabling the device.
>
> Proposed fix for "sky2 panic under load" reported by Berck E. Nash.
>
> Signed-off-by: Mike McCormack<mikem@...g3k.org>
> ---
>   drivers/net/sky2.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
> index faa4841..8ae8520 100644
> --- a/drivers/net/sky2.c
> +++ b/drivers/net/sky2.c
> @@ -3176,7 +3176,9 @@ static void sky2_reset(struct sky2_hw *hw)
>   static void sky2_detach(struct net_device *dev)
>   {
>   	if (netif_running(dev)) {
> +		netif_tx_lock(dev);
>   		netif_device_detach(dev);	/* stop txq */
> +		netif_tx_unlock(dev);
>   		sky2_down(dev);
>   	}
>   }
>    

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html