netdev - Re: [PATCH v2 RFC 2/5] TCPCT part 2b: remove old tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Dec 2009 14:44:21 -0500
From:	William Allen Simpson <william.allen.simpson@...il.com>
To:	Linux Kernel Network Developers <netdev@...r.kernel.org>
CC:	Michael Chan <mchan@...adcom.com>
Subject: Re: [PATCH v2 RFC 2/5] TCPCT part 2b: remove old tcp_optlen function

In the only two existing files using the old tcp_optlen() function,
clean up confusing and inconsistent mixing of both byte and word
offsets.  Document assumptions.

No semantic changes.  The drivers should function exactly as existing.
Untested.  No response from testers in 9+ weeks.

Requires:
   TCPCT part 2a: TCP header pointer functions

Signed-off-by: William.Allen.Simpson@...il.com
CC: Michael Chan <mchan@...adcom.com>
---
  drivers/net/bnx2.c  |   26 +++++++++++++--------
  drivers/net/tg3.c   |   59 ++++++++++++++++++++++++++-------------------------
  include/linux/tcp.h |    5 ----
  3 files changed, 46 insertions(+), 44 deletions(-)

View attachment "TCPCT+2b2.patch" of type "text/plain" (6943 bytes)