netdev - Re: [PATCH] dmfe/tulip: Let dmfe handle DM910x except for SPARC on-board chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 03 Jan 2010 21:36:28 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	grundler@...isc-linux.org
Cc:	ben@...adent.org.uk, brandon@...p.org, grundler@...gle.com,
	tobias@...gis.se, kyle@...artin.ca, netdev@...r.kernel.org
Subject: Re: [PATCH] dmfe/tulip: Let dmfe handle DM910x except for SPARC
 on-board chips

From: Grant Grundler <grundler@...isc-linux.org>
Date: Tue, 29 Dec 2009 11:41:52 -0700

> On Tue, Dec 29, 2009 at 06:22:28PM +0000, Ben Hutchings wrote:
>> The Davicom DM9100 and DM9102 chips are used on the motherboards of
>> some SPARC systems (supported by the tulip driver) and also in PCI
>> expansion cards (supported by the dmfe driver).  There is no
>> difference in the PCI device ids for the two different configurations,
>> so these drivers both claim the device ids.  However, it is possible
>> to distinguish the two configurations by the presence of Open Firmware
>> properties for them, so we do that.
>> 
>> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> 
> Acked-by: Grant Grundler <grundler@...isc-linux.org>
> 
> I've reviewed the code and it looks fine to me.
> 
> Only thing I'm not sure about is if "KERN_ERR" is
> the right priority for what are essentially warning
> messages. Not harmful. But could be annoying to some
> Sparc users who get this on every boot when both modules
> are present and loaded in the "wrong" order.

I agree, KERN_INFO is more appropriate here.

Also, for the of_get_property() calls, you don't need to pass
in a dummy "&len", just pass NULL.  This will avoid the dummy
local variable 'len'.

Make these two fixups and I'll apply this to net-2.6

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html