netdev - Re: [PATCH] sis900: print warning if MAC address is not available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100103.215727.177625500.davem@davemloft.net>
Date:	Sun, 03 Jan 2010 21:57:27 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	venza@...wnhat.org
Cc:	netdev@...r.kernel.org, akpm@...ux-foundation.org,
	erik.andren@...il.com
Subject: Re: [PATCH] sis900: print warning if MAC address is not available

From: Daniele Venzano <venza@...wnhat.org>
Date: Wed, 30 Dec 2009 19:22:43 +0100

> The attached patch prints a warning if the MAC address is all 0s in the
> sis900 driver.
> 
> The patch prints a warning whenever the MAC address read from the
> hardware is composed of all zeros.
> If the address cannot be read at all for some reason, the driver is
> already doing the right thing and bails out.
> In reference to bug 11649 from bugzilla.
> 
> Please test this patch, it is trivial, but I only test-compiled it since
> I no longer have the hardware.
> 
> Signed-off-by: Daniele Venzano <linux@...wnhat.org>

We have a way to check for a valid mac address: is_valid_ether_addr()

Please use it instead of your home-grown function.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html