netdev - Re: [PATCH] ipvs: Add boundary check on ioctl arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B420B97.5000302@trash.net>
Date:	Mon, 04 Jan 2010 16:39:03 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Arjan van de Ven <arjan@...ux.intel.com>
CC:	Simon Horman <horms@...ge.net.au>, netdev@...r.kernel.org,
	lvs-devel@...r.kernel.org, Wensong Zhang <wensong@...ux-vs.org>,
	Julian Anastasov <ja@....bg>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] ipvs: Add boundary check on ioctl arguments

Arjan van de Ven wrote:
> On 1/4/2010 5:59, Patrick McHardy wrote:
> 
> [sorry for the late response, just got back from a good holiday, which
> means no work email access ;-) ]
> 
>> Simon Horman wrote:
> 
>>> I agree with Julian's assessment that your patch shouldn't be
>>> necessary, but on the other hand I think that the checks are
>>> reasonable. Your original patch made checks of the form of
>>> "cmd>  IP_VS_SO_GET_MAX + 1". I have updated this to
>>> "cmd>  IP_VS_SO_GET_MAX", as suggested by Julian, as the optmax
>>> elements of struct nf_sockopt_ops set a non-inclusive range.
>>>
>>> http://lkml.indiana.edu/hypermail/linux/kernel/0910.0/00852.html
>>>
>>> Index: net-next-2.6/net/netfilter/ipvs/ip_vs_ctl.c
>>
>> As a bugfix, this seems more appropriate for net-2.6.git. Please let
>> me know which tree you want me to apply this to.
> 
> this really ought to go into 2.6.33.....

Thanks, applied and will send it upstream soon.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html