netdev - Re: [PATCH] via-velocity: add netpoll functionality for the benefit of netconsole

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100105072800.13dba6d2@marrow.netinsight.se>
Date:	Tue, 5 Jan 2010 07:28:00 +0100
From:	Simon Kagstrom <simon.kagstrom@...insight.net>
To:	Jan Ceuleers <jan.ceuleers@...puter.org>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
	Stéphane Berthelot <sberthelot@...sfr.com>
Subject: Re: [PATCH] via-velocity: add netpoll functionality for the benefit
 of netconsole

Hi,

Does the patch still work with the new NAPI support in the driver? Some
comments below:

On Mon, 04 Jan 2010 19:32:32 +0100
Jan Ceuleers <jan.ceuleers@...puter.org> wrote:

> +static void velocity_poll_controller(struct net_device *dev)
> +{
> +	disable_irq(dev->irq);
> +	velocity_intr(dev->irq, dev);
> +	enable_irq(dev->irq);
> +}

This should probably have an

#ifdef CONFIG_NET_POLL_CONTROLLER
...
#endif

around it since

> @@ -2628,6 +2642,9 @@ static const struct net_device_ops velocity_netdev_ops = {
>  	.ndo_vlan_rx_add_vid	= velocity_vlan_rx_add_vid,
>  	.ndo_vlan_rx_kill_vid	= velocity_vlan_rx_kill_vid,
>  	.ndo_vlan_rx_register	= velocity_vlan_rx_register,
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +	.ndo_poll_controller	= velocity_poll_controller,
> +#endif

This one has it (to avoid a warning when building without it).

// Simon
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html