netdev - Re: [PATCH] net: cdc_ether.c: Add SE J105i to device whitelist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87iqbhuhre.fsf@nemi.mork.no>
Date:	Tue, 05 Jan 2010 08:34:45 +0100
From:	Bjørn Mork <bjorn@...k.no>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: cdc_ether.c: Add SE J105i to device whitelist

Marcel Holtmann <marcel@...tmann.org> writes:

> Hi Bjorn,
>
>> >> This patch adds the Sony Ericsson J105i (Naite)
>> >> mobile phone to the cdc_ether device whitelist,
>> >> enabling access to the modem.
>> >> 
>> >> I would think more SE models of this generation
>> >> (2009Q3) with builtin HSDPA modules also needs
>> >> to be added to this list.
>> >
>> > I do prefer if we NOT use the mbm_info details for this since they are
>> > clearly for mobile broadband cards with FLAG_WWAN.
>> 
>> Assuming that these devices can be configured just like the WWAN cards
>> by sending commands to the associated ACM* or WDM* interfaces, why would
>> you treat them differently?  Because they've got a keyboard and a
>> display?
>
> these are not like MBM devices WWAN cards. The MBM cards require to
> setup the PDP context before the card will become ready. With an actual
> phone you are already set.

You are?  AFAIK, the PDP context *may* be configured using the phone UI
but it still needs to be setup.  And there are good reasons why you'd
like to configure/setup/verify the PDP context from the PC even if one
is setup using the phone UI. You will at least need to verify that a PDP
context actually *is* setup.  And you might want to use a different APN
than the one used when surfing from the phone.  You might even want to
choose different APNs depending on context (for VPN access, e.g)

> So these are Ethernet devices and not WWAN cards.

Well, I argued that the WWAN card were Ethernet devices.  I realise that
they've been defined otherwise now.  What I'm trying to understand are
the finer details of this definition.  Exactly what defines a WWAN card?

>> > Since this is a phone where the setup of the connection is done via the
>> > phone. And you just treat this as an Ethernet device and run DHCP, then
>> > please create a se_info or similar with FLAG_ETHER.
>> 
>> Why would anyone want to setup the connection via the phone?  That seems
>> unnecessary cumbersome. I'd prefer such devices to be auto-configured
>> just like any other WWAN device.
>
> Are they WWAN devices? What these do is basically tethering via an
> Ethernet like device. It does not require a telephony stack to drive
> this hardware.

Do they connect automatically, or do you need to initiate the connection
somehow?

> We require a proper DEVTYPE classification and these don't fall into the
> category of WWAN devices. They can be treated like every other Ethernet
> card and should be classified like this. We have FLAG_ETHER for this, so
> please use that one.

I believe the WWAN cards also can be treated like every other USB
Ethernet device, as far as the kernel is concerned.  Any differences are
easily resolved by userspace applications. 

So I'm still trying to figure out what makes a WWAN device special wrt
the kernel.  Thanks for explaining.

Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html