[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4B45E1D7.80407@st.com>
Date: Thu, 07 Jan 2010 14:29:59 +0100
From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
To: Jean-Hugues Deschenes <jean-hugues.deschenes@...asic.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH 03/13] stmmac: add the new Header file for stmmac platform
data
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Jean-Hugues,
Jean-Hugues Deschenes wrote:
>
> Giuseppe CAVALLARO wrote:
>> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com>
>> ---
>> include/linux/stmmac.h | 53
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 files changed, 53 insertions(+), 0 deletions(-)
>> create mode 100644 include/linux/stmmac.h
>>
>> diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h
>> new file mode 100644
>> index 0000000..32bfd1a
>> --- /dev/null
>> +++ b/include/linux/stmmac.h
>>
> Coming to think of it, it might be preferable to locate this file in
> drivers/net/stmmac/stmmac_plat.h and have the platform-specific code do
> inclusions like: #include "../../../drivers/net/stmmac/stmmac_plat.h"
Indeed, I don't like the include/linux/stmmac.h file but it's not only,
see the dm9000.h file.
Moreover, moving this header file within drivers/net/stmmac directory,
each board setup file (arch/sh/boards/mach-<name>/setup.c should have
#include "../../../../drivers/net/stmmac/stmmac_plat.h". Is it a good
solution? So i can think the include/linux/stmmac.h remains the way
(like for the architectures that use the Davicom DM9000 adapter).
At any rate, welcome advice as usual.
Regards,
Peppe
>
> jh
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAktF4dcACgkQ2Xo3j31MSSKTFwCfXwrMhGK/3zin53G+oqMGgZgf
Y2AAmwWNvVARWEgM8VdNSyp5xY7ntlk6
=XwJD
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists