netdev - Re: [RFC 4/9] snet: introduce snet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2d41mm05t.fsf@ssh.synack.fr>
Date:	Thu, 07 Jan 2010 15:58:54 +0100
From:	Samir Bellabes <sam@...ack.fr>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	linux-security-module@...r.kernel.org, jamal <hadi@...erus.ca>,
	Evgeniy Polyakov <zbr@...emap.net>,
	Neil Horman <nhorman@...driver.com>, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org
Subject: Re: [RFC 4/9] snet: introduce snet_core.c and snet.h

Samir Bellabes <sam@...ack.fr> writes:

> -void snet_verdict_flush(void)
> -{
> -	write_lock_bh(&snet_vdh_lock);
> -	if (snet_vdh)
> -		__snet_verdict_flush();
> -	write_unlock_bh(&snet_vdh_lock);
> +	write_untlock_bh(&snet_vdh_lock);

I introduce a typo here, (untblock)
this is fixed now.
I'm sorry for not getting this at first time.

sam

>  	return;
>  }
>  
> @@ -197,13 +181,7 @@ out:
>  /* exit function */
>  int snet_verdict_exit(void)
>  {
> -	write_lock_bh(&snet_vdh_lock);
> -	if (snet_vdh) {
> -		__snet_verdict_flush();
> -		kfree(snet_vdh);
> -		snet_vdh = NULL;
> -	}
> -	write_unlock_bh(&snet_vdh_lock);
> -
> +	kfree(snet_vdh);
> +	snet_vdh = NULL;
>  	return 0;
>  }
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html