netdev - Re: [PATCH net-next v3 2/3] can: mscan-mpc5xxx: add support for the MPC512x processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100107162113.GB7394@pengutronix.de>
Date:	Thu, 7 Jan 2010 17:21:13 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Wolfgang Grandegger <wg@...ndegger.com>
Cc:	Netdev@...r.kernel.org, Socketcan-core@...ts.berlios.de,
	Linuxppc-dev@...ts.ozlabs.org, Devicetree-discuss@...ts.ozlabs.org,
	Wolfgang Grandegger <wg@...x.de>
Subject: Re: [PATCH net-next v3 2/3] can: mscan-mpc5xxx: add support for
	the MPC512x processor

On Thu, Jan 07, 2010 at 03:10:20PM +0100, Wolfgang Grandegger wrote:
> From: Wolfgang Grandegger <wg@...x.de>
> 
> The main differences compared to the MSCAN on the MPC5200 are:
> 
> - More flexibility in choosing the CAN source clock and frequency:
> 
>   Three different clock sources can be selected: "ip", "ref" or "sys".
>   For the latter two, a clock divider can be defined as well. If the
>   clock source is not specified by the device tree, we first try to
>   find an optimal CAN source clock based on the system clock. If that
>   is not possible, the reference clock will be used.
> 
> - The behavior of bus-off recovery is configurable:
> 
>   To comply with the usual handling of Socket-CAN bus-off recovery,
>   "recovery on request" is selected (instead of automatic recovery).
> 
> Note that only MPC5121 Rev. 2 and later is supported.
> 
> Signed-off-by: Wolfgang Grandegger <wg@...x.de>

Reviewed-by: Wolfram Sang <w.sang@...gutronix.de>

It still works with our board and I didn't find anything else to comment on.

Thanks, Wolfgang!

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)