netdev - RE: [PATCHv2 NEXT 1/2] qlcnic: Qlogic ethernet driver for CNA devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7608421F3572AB4292BB2532AE89D5658B0BAE95E4@AVEXMB1.qlogic.org>
Date:	Thu, 7 Jan 2010 10:40:02 -0800
From:	Dhananjay Phadke <dhananjay.phadke@...gic.com>
To:	Stephen Hemminger <shemminger@...tta.com>,
	Amit Salecha <amit.salecha@...gic.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCHv2 NEXT 1/2] qlcnic: Qlogic ethernet driver for CNA
 devices

> * crb_lock is setup as rwlock but you only use as writer;
>  also isn't this already covered by mem_lock?
> 
> * mem_lock could/should be mutex
>  can ioremap want to sleep?

crb_lock and mem_lock are inherited from netxen_nic which
needed separate locks for indirect register and memory
access on NX2031 controllers.

You have already touched the reason they need to be separate,
on card memory is only read by applications and needs ioremap,
whereas registers may be accessed in atomic context.

-Dhananjay

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html