netdev - Re: BSD 4.2 style TCP keepalives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100106.192131.193700514.davem@davemloft.net>
Date:	Wed, 06 Jan 2010 19:21:31 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	netdev@...r.kernel.org
Cc:	nhorman@...driver.com, ilpo.jarvinen@...sinki.fi
Subject: Re: BSD 4.2 style TCP keepalives

From: David Miller <davem@...emloft.net>
Date: Wed, 06 Jan 2010 16:14:54 -0800 (PST)

> +#if 1
> +	/* Construct BSD 4.2 style zero-window probe with one
> +	 * out-of-window garbage data byte.
> +	 *
> +	 * XXX this does the wrong thing when 'urgent' is true
> +	 */
> +	{
> +		unsigned char *garbage_byte = skb_put(skb, 1);
> +
> +		*garbage_byte = 0xff;
> +		TCP_SKB_CB(skb)->end_seq++;
> +	}
> +#endif

This doesn't work so well, because the checksum will be wrong.
The patch at the end of this email should work better.

And maybe that's a clue, because with this upstream Linux does ACK the
probe.  So I wonder if the Windows 2000 systems don't calculate the
checksum correctly?

More mysterious by the minute :-)

diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index 383ce23..ce0ae32 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -2727,6 +2727,20 @@ static int tcp_xmit_probe_skb(struct sock *sk, int urgent)
 	 * send it.
 	 */
 	tcp_init_nondata_skb(skb, tp->snd_una - !urgent, TCPCB_FLAG_ACK);
+#if 1
+	/* Construct BSD 4.2 style zero-window probe with one
+	 * out-of-window garbage data byte.
+	 *
+	 * XXX this does the wrong thing when 'urgent' is true
+	 */
+	{
+		unsigned char *garbage_byte = skb_put(skb, 1);
+
+		*garbage_byte = 0xff;
+		TCP_SKB_CB(skb)->end_seq++;
+		skb->ip_summed = CHECKSUM_PARTIAL;
+	}
+#endif
 	TCP_SKB_CB(skb)->when = tcp_time_stamp;
 	return tcp_transmit_skb(sk, skb, 0, GFP_ATOMIC);
 }
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html