netdev - Re: [PATCH net-next-2.6] fix bonding: allow arp_ip_targets on separate vlans to use arp validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100107.004127.77258555.davem@davemloft.net>
Date:	Thu, 07 Jan 2010 00:41:27 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	fubar@...ibm.com, andy@...yhouse.net, therbert@...gle.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] fix bonding: allow arp_ip_targets on
 separate vlans to use arp validation

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 07 Jan 2010 09:37:58 +0100

> Le 07/01/2010 00:53, Jay Vosburgh a écrit :
>> Andy Gospodarek <andy@...yhouse.net> wrote:
>> 
>>> This patch fixes up a problem with found with commit
>>> 1f3c8804acba841b5573b953f5560d2683d2db0d.  The original change
>>> overloaded null_or_orig, but doing that prevented any packet handlers
>>> that were not tied to a specific device (i.e. ptype->dev == NULL) from
>>> ever receiving any frames.
>>>
>>> The null_or_orig variable cannot be overloaded, and must be kept as NULL
>>> to prevent the frame from being ignored by packet handlers designed to
>>> accept frames on any interface.
>>>
>>> Signed-off-by: Andy Gospodarek <andy@...yhouse.net>
>> 
>> 	Tested, and it appears to work fine.  Tcpdump also appears to
>> behave rationally.
>> 
>> 	-J
>> 
>> Signed-off-by: Jay Vosburgh <fubar@...ibm.com>
> 
> Tested as well on my machine, I confirm this fixes the problem I had.
> 
> Acked-by: Eric Dumazet <eric.dumazet@...il.com>

Thanks I'll add this to net-next-2.6 to fix the problem.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html