netdev - Re: [PATCH v2] dmfe/tulip: Let dmfe handle DM910x except for SPARC on-board chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100107.010651.18296756.davem@davemloft.net>
Date:	Thu, 07 Jan 2010 01:06:51 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	grundler@...isc-linux.org
Cc:	ben@...adent.org.uk, brandon@...p.org, grundler@...gle.com,
	tobias@...gis.se, kyle@...artin.ca, netdev@...r.kernel.org
Subject: Re: [PATCH v2] dmfe/tulip: Let dmfe handle DM910x except for SPARC
 on-board chips

From: David Miller <davem@...emloft.net>
Date: Thu, 07 Jan 2010 00:51:25 -0800 (PST)

> From: Grant Grundler <grundler@...isc-linux.org>
> Date: Tue, 5 Jan 2010 09:58:17 -0700
> 
>> On Tue, Jan 05, 2010 at 03:03:08AM +0000, Ben Hutchings wrote:
>>> The Davicom DM9100 and DM9102 chips are used on the motherboards of
>>> some SPARC systems (supported by the tulip driver) and also in PCI
>>> expansion cards (supported by the dmfe driver).  There is no
>>> difference in the PCI device ids for the two different configurations,
>>> so these drivers both claim the device ids.  However, it is possible
>>> to distinguish the two configurations by the presence of Open Firmware
>>> properties for them, so we do that.
>>> 
>>> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
>> 
>> Signed-off-by: Grant Grundler <grundler@...isc-linux.org>
> 
> Applied, thanks everyone.

Sorry, had to revert, doesn't build:

  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  SYMLINK include/asm -> include/asm-sparc
  CALL    scripts/checksyscalls.sh
  CC [M]  drivers/net/tulip/dmfe.o
drivers/net/tulip/dmfe.c: In function 'dmfe_init_one':
drivers/net/tulip/dmfe.c:386: warning: suggest parentheses around && within ||
drivers/net/tulip/dmfe.c:389: error: implicit declaration of function 'of_get_property'
make[1]: *** [drivers/net/tulip/dmfe.o] Error 1
make: *** [drivers/net/tulip/dmfe.o] Error 2

Please fix this up and resubmit, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html