netdev - Re: [PATCH] tcp: account SYN-ACK timeouts & retransmissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100107.172507.04893002.davem@davemloft.net>
Date:	Thu, 07 Jan 2010 17:25:07 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	opurdila@...acom.com
Cc:	netdev@...r.kernel.org, mpyatkovskiy@...acom.com
Subject: Re: [PATCH] tcp: account SYN-ACK timeouts & retransmissions

From: Octavian Purdila <opurdila@...acom.com>
Date: Wed,  6 Jan 2010 22:10:58 +0200

> Signed-off-by: Maksim Pyatkovskiy <mpyatkovskiy@...acom.com>
> Signed-off-by: Octavian Purdila <opurdila@...acom.com>

RETRANSSEGS is meant to count data segments retransmits, not pure
control frames.

Similarly for TCPTIMEOUTS, it's mean for data retransmit timeouts.

If you overload these statistics with other similar events, they
become less meaningful.

Finally, bumping TCP specific statistics from the generic INET
connection oriented socket code is a huge no-no.  That code is
written to be protocol agnostic.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html