netdev - Re: [PATCH] drivers/net/defxx.c: use %pMF to show MAC address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1001080143250.13474@eddie.linux-mips.org>
Date:	Fri, 8 Jan 2010 02:06:14 +0000 (GMT)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Joe Perches <joe@...ches.com>
cc:	H Hartley Sweeten <hartleys@...ionengravers.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH] drivers/net/defxx.c: use %pMF to show MAC address

On Thu, 7 Jan 2010, Joe Perches wrote:

> On Thu, 2010-01-07 at 16:24 -0700, H Hartley Sweeten wrote:
> > Use the %pMF kernel extension to display the MAC address.
> > The address will still be displayed in the FDDI Canonical format.
> 
> > diff --git a/drivers/net/defxx.c b/drivers/net/defxx.c
> > index 6a6ea03..e4eac4b 100644
> > --- a/drivers/net/defxx.c
> > +++ b/drivers/net/defxx.c
> > @@ -1052,12 +1052,9 @@ static int __devinit dfx_driver_init(struct net_device *dev,
> >  		board_name = "DEFEA";
> >  	if (dfx_bus_pci)
> >  		board_name = "DEFPA";
> > -	pr_info("%s: %s at %saddr = 0x%llx, IRQ = %d, "
> > -		"Hardware addr = %02X-%02X-%02X-%02X-%02X-%02X\n",
> > +	pr_info("%s: %s at %saddr = 0x%llx, IRQ = %d, Hardware addr = %pMF\n",
> >  		print_name, board_name, dfx_use_mmio ? "" : "I/O ",
> 
> I believe the output will _now_ be in the canonical form.
> Before it wasn't bit reversed.  Now it should be.

 Output was correct -- why would you assume otherwise?  The bit order in 
the MLA (My Long Address) register as retrieved from the MAC chip by 
board's firmware has nothing to do with the wire order and is already in 
the canonical form (the same applies to CAM entries and frame headers) -- 
the board designers were sane people.

 With the two patches in place the output produced is now broken. :(

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html