netdev - [PATCH] genetlink: optimize ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2bph5kodr.fsf@ssh.synack.fr>
Date:	Fri, 08 Jan 2010 09:10:56 +0100
From:	Samir Bellabes <sam@...ack.fr>
To:	"David S. Miller" <davem@...emloft.net>
Cc:	Thomas Graf <tgraf@...g.ch>,
	Johannes Berg <johannes@...solutions.net>,
	jamal <hadi@...erus.ca>, netdev@...r.kernel.org
Subject: [PATCH] genetlink: optimize ctrl_dumpfamily()

commit f3257ff67aac80d423227eae89281e506fed8cd6
Author: Samir Bellabes <sam@...ack.fr>
Date:   Fri Jan 8 08:44:41 2010 +0100

    genetlink: optimize ctrl_dumpfamily()
    
    there is a unnecessary test which can be replaced by a good initialization in
    the 'for' statement
    
    Noticed by Serge E. Hallyn <serue@...ibm.com>
    
    Signed-off-by: Samir Bellabes <sam@...ack.fr>

diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c
index d07ecda..a4b6e14 100644
--- a/net/netlink/genetlink.c
+++ b/net/netlink/genetlink.c
@@ -681,9 +681,7 @@ static int ctrl_dumpfamily(struct sk_buff *skb, struct netlink_callback *cb)
 	int chains_to_skip = cb->args[0];
 	int fams_to_skip = cb->args[1];
 
-	for (i = 0; i < GENL_FAM_TAB_SIZE; i++) {
-		if (i < chains_to_skip)
-			continue;
+	for (i = chains_to_skip; i < GENL_FAM_TAB_SIZE; i++) {
 		n = 0;
 		list_for_each_entry(rt, genl_family_chain(i), family_list) {
 			if (!rt->netnsok && !net_eq(net, &init_net))
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html