netdev - Re: [net-next-2.6 PATCH 5/5] ixgbe: Add support for the new ethtool n-tuple programming interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100108.002642.221825262.davem@davemloft.net>
Date:	Fri, 08 Jan 2010 00:26:42 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	peter.p.waskiewicz.jr@...el.com, deri@...p.org,
	joseph.gasparakis@...el.com
Subject: Re: [net-next-2.6 PATCH 5/5] ixgbe: Add support for the new
 ethtool n-tuple programming interface

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Wed, 06 Jan 2010 20:49:53 -0800

> +	/*
> +	 * Don't allow programming if we're not in perfect filter mode, or
> +	 * if the action is a queue greater than the number of online Tx
> +	 * queues.
> +	 */
> +	if ((!(adapter->flags & IXGBE_FLAG_FDIR_PERFECT_CAPABLE)) ||
> +	    (fs.action >= adapter->num_tx_queues))
> +		return -EINVAL;

This is yet another argument for making the perfect filter mode
control an ethtool setting, why should the user have to reload the
module just to get that boolean setting fixed up when they want to
load filters?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html