netdev - Re: [RFC PATCH] net: consolidate netif_needs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100108.010049.218930041.davem@davemloft.net>
Date:	Fri, 08 Jan 2010 01:00:49 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	john.r.fastabend@...el.com, netdev@...r.kernel.org
Subject: Re: [RFC PATCH] net: consolidate netif_needs_gso() checks

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Thu, 7 Jan 2010 16:07:21 +1100

> On Wed, Jan 06, 2010 at 08:34:23PM -0800, David Miller wrote:
>> From: John Fastabend <john.r.fastabend@...el.com>
>> Date: Mon, 04 Jan 2010 10:21:53 +0000
>> 
>> > netif_needs_gso() is checked twice in the TX path once,
>> > before submitting the skb to the qdisc and once after
>> > it is dequeued from the qdisc just before calling
>> > ndo_hard_start().  This opens a window for a user to
>> > change the gso/tso or tx checksum settings that can
>> > cause netif_needs_gso to be true in one check and false
>> > in the other.
>> > 
>> > Specifically, changing TX checksum setting may cause
>> > the warning in skb_gso_segment() to be triggered if
>> > the checksum is calculated earlier.
>> > 
>> > This consolidates the netif_needs_gso() calls so that
>> > the stack only checks if gso is needed after the skb
>> > is dequeued from the qdisc.  Or if the device has no
>> > queue then before dev_hard_start_xmit() in dev_queue_xmit().
>> > 
>> > Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
>> 
>> Herbert, please review.
> 
> Looks fine to me.  I have just one suggestion.  The queueless
> case also calls dev_hard_start_xmit so we should be able to
> remove the existing !need_gso code from dev_queue_xmit completely.

John, please make these changes.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html