lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 08 Jan 2010 19:33:15 +0900
From:	Taku Izumi <>
To:	Laurent Chavey <>
CC:, Bruce Allan <>,
	"David S. Miller" <>,
	Jesse Brandeburg <>,
	John Ronciak <>,
	"Kirsher, Jeffrey T" <>,
	PJ Waskiewicz <>,
	Koki Sanagi <>,
	Kenji Kaneshige <>
Subject: Re: [PATCH 2/3] igb: add registers etc. printout code just before
 	resetting adapters

(2010/01/08 4:16), Laurent Chavey wrote:
> since hexdump() is already in patch 1/3, could this be moved
> to lib/hexdump.c (or could the code make use of hex_dump_to_buffer())
> same comment as for patch1/3 for the call to igb_dump()
> [use of dump_flag] I can see how it the flag is use thru out the
> call but did not see how it prevents the  logging of netdev
> info.
> it looks like the code in each of the case statement is identical
> except for some naming. Could this be converted to
> a data driven table (register definition, type, dump routine.)
> The later may actually be leveraged across drivers and
> use full to implement some semi standard debug dump
> reg tool.

 Thank you for your useful comment. I'll reflect your comment and
 improve later.

Best regards,
Taku Izumi

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists