netdev - Re: [PATCH] IPv6: fix rt_lookup in pmtu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100110.131524.241344047.davem@davemloft.net>
Date:	Sun, 10 Jan 2010 13:15:24 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	lorenzo@...gle.com
Cc:	zenczykowski@...il.com, therbert@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH] IPv6: fix rt_lookup in pmtu_discovery

From: Lorenzo Colitti <lorenzo@...gle.com>
Date: Fri, 8 Jan 2010 16:12:55 -0800

> How about this patch instead?

It's still not fully correct.

You can't ignore source based routing and pretend it doesn't
exist or matter.

That's why ipv4 (and this code you are trying to change) needs to
iterate over saddr [ ANY, saddr ], and that's why you need that
special loop that iterates over all combinations of ifindex/saddr.

This is what I've been asking you to do from the beginning, please
implement it this way and I'll apply your patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html