netdev - Re: tg3 appears to be sick in 2.6.33

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100111175911.GA10496@xw6200.broadcom.net>
Date:	Mon, 11 Jan 2010 09:59:11 -0800
From:	"Matt Carlson" <mcarlson@...adcom.com>
To:	"David Miller" <davem@...emloft.net>
cc:	"Matthew Carlson" <mcarlson@...adcom.com>,
	"dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"jfeeney@...hat.com" <jfeeney@...hat.com>
Subject: Re: tg3 appears to be sick in 2.6.33

On Sun, Jan 10, 2010 at 01:52:42PM -0800, David Miller wrote:
> From: "Matt Carlson" <mcarlson@...adcom.com>
> Date: Fri, 8 Jan 2010 11:42:22 -0800
> 
> > [PATCH] tg3: Fix std rx prod ring handling
> > 
> > There are some tg3 devices that require the driver to post new rx
> > buffers in smaller increments.  Commit
> > 4361935afe3abc3e5a93006b99197fac1fabbd50, "tg3: Consider
> > rx_std_prod_idx a hw mailbox" changed how the driver tracks the rx
> > producer ring updates, but it does not make any special considerations
> > for the above-mentioned devices.  For those devices, it is possible for
> > the driver to hit the special case path, which updates the hardware
> > mailbox register but skips updating the shadow software mailbox member.
> > If the special case path represents the final mailbox update for this
> > ISR iteration, the hardware and software mailbox values will be out of
> > sync.  Ultimately, this will cause the driver to use a stale mailbox
> > value on the next iteration, which will appear to the hardware as a
> > large rx buffer update.  Bad things ensue.
> > 
> > The fix is to update the software shadow mailbox member when the special
> > case path is taken.
> > 
> > Signed-off-by: Matt Carlson <mcarlson@...adcom.com>
> 
> Matt, since we have positive testing, want me to apply this?

I have a small patchset queued up for net-2.6.  Let me just include this
one into the mix and submit it all at once.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html