lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 11 Jan 2010 13:52:12 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Taku Izumi <izumi.taku@...fujitsu.com>
Cc:	netdev@...r.kernel.org, Bruce Allan <bruce.w.allan@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	John Ronciak <john.ronciak@...el.com>,
	PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>,
	Koki Sanagi <sanagi.koki@...fujitsu.com>,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>
Subject: Re: [PATCH 0/3] e1000e,igb,ixgbe: add registers etc. printout code 
	just before resetting adapters

2010/1/7 Taku Izumi <izumi.taku@...fujitsu.com>:
>
> This patchset adds registers etc. printout code just before resetting adapters
> to e1000e, igb, ixgbe modules. The registers, tx/rx rings status, descriptors,
> and buffer info will be helpful for detecting the root cause of adapters reset.
>
> This patchset is based on the following Jesse's debug patch of e1000e module.
>  http://marc.info/?l=linux-netdev&m=121446492912285&w=2
> I think that code is very useful, and should be comitted to upstream.
>
> The main difference between Jesse's patch and mine is as follows:
>  - the function which invokes xxx_dump function. (xxx_clean_tx_irq -> xxx_reset_task)
>  - add the "dump_flag" module option to select category of printout
>
> The default output is netdevice status (transstart, last_rx), registers,
> and tx/rx rings' simple information. TX/RX descriptors information and
> buffer_info  can be output by changing the dump_flag module option, but,
> of course, the amount of output becomes quite large.
>
>  *[PATCH 1/3] e1000e: add registers etc. printout code just before resetting adapters
>  *[PATCH 2/3] igb: add registers etc. printout code just before resetting adapters
>  *[PATCH 3/3] ixgbe: add registers etc. printout code just before resetting adapters
>
> Best regards,
> Taku Izumi <izumi.taku@...fujitsu.com>
>

Thanks Taku!  I have added your patches to my queue of patches.  Let
me know you are working on an updated version of these patches based
on Laurent Chavey's comments so that I can suck in your updated
versions of the patches when they become available.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists