[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20100111.222202.66778648.davem@davemloft.net>
Date: Mon, 11 Jan 2010 22:22:02 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: ron.mercer@...gic.com
Cc: netdev@...r.kernel.org
Subject: Re: [net-next PATCH 0/8] qlge: Add firmware coredump functionality.
From: Ron Mercer <ron.mercer@...gic.com>
Date: Mon, 11 Jan 2010 17:12:57 -0800
> Dump all regsiters and on chip RAM when a fatal firmware error is
> encountered. This features is turn on by default but can be
> turned off with a module parameter.
There is no way you should crap into someone's kernel log
with a large amount of information by default.
Yes, this is true even on fatal errors.
If you can't dump the information in say a dozen lines, it
is more trouble than it's worth as a default.
Make the default to off. Users can be asked to turn it on
if you need to capture more information for diagnostics,
and you personally can turn it on by default when doing
development.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists