netdev - Re: [Bug #14925] sky2 panic under load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100111.161419.138918787.davem@davemloft.net>
Date:	Mon, 11 Jan 2010 16:14:19 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jarkao2@...il.com
Cc:	shemminger@...tta.com, mikem@...g3k.org, flyboy@...il.com,
	rjw@...k.pl, netdev@...r.kernel.org
Subject: Re: [Bug #14925] sky2 panic under load

From: Jarek Poplawski <jarkao2@...il.com>
Date: Mon, 11 Jan 2010 23:07:54 +0100

> I don't agree: you both try to make this check more specific.
> Actually, since this problem is quite tricky, I wondered about
> making it more genaral and visible for other maintainers by
> adding something like netif_wake_queue_present() with the
> check and some comment.

This detracts from the real problem.

The issue is that we have a code path bringing a device down, which
uses helper routines which are meant to be executed when the device is
up and functioning normally.

That's the bug.

No other driver does silly things like call helper routines which wake
the TX queue when taking the chip down.

Fix that, not the immediate symptoms.  Write a routine that
unconditionally clears the TX queue, frees the packets, etc. and
has none of the wake logic.

That's what most other driver do, and those that don't should be
fixed similarly.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html