[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100112113619.GA26806@linux-mips.org>
Date: Tue, 12 Jan 2010 12:36:19 +0100
From: Ralf Baechle <ralf@...ux-mips.org>
To: Greg KH <gregkh@...e.de>
Cc: David Daney <ddaney@...iumnetworks.com>,
Sergei Shtylyov <sshtylyov@...mvista.com>,
linux-mips@...ux-mips.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/7] MIPS: Octeon: Fix EIO handling.
On Thu, Jan 07, 2010 at 01:59:50PM -0800, Greg KH wrote:
> >>> If an interrupt handler disables interrupts, the EOI function will
> >>> just reenable them. This will put us in an endless loop when the
> >>> upcoming Ethernet driver patches are applied.
> >>>
> >>> Only reenable the interrupt on EOI if it is not IRQ_DISABLED. This
> >>> requires that the EIO function be separate from the ENABLE function.
> >>> We also rename the ACK functions to correspond with their function.
> >>>
> >>> Signed-off-by: David Daney <ddaney@...iumnetworks.com>
> >>>
> >>
> >> I guess the subject should read "EIO", not "EIO"...
> >>
> >
> > Indeed. The compiler didn't catch that one.
> >
> > Perhaps Ralf can fix it if he merges it, otherwise I can resubmit with
> > corrected spelling.
>
> I can change it when merging, don't worry about it.
This is a driver specific to a specific MIPS platform so I think this
series should be merged via the MIPS tree and assuming Greg is ok with that
I have merged this into my tree.
Ralf
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists