netdev - RE: [net-next-2.6 PATCH 3/5] ethtool: Introduce n-tuple filter programming support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F86E8680A7D9D74A99DC6345E35A692950109528@orsmsx503.amr.corp.intel.com>
Date:	Tue, 12 Jan 2010 11:13:54 -0800
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	Ben Hutchings <bhutchings@...arflare.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>, Luca Deri <deri@...p.org>,
	"Gasparakis, Joseph" <joseph.gasparakis@...el.com>
Subject: RE: [net-next-2.6 PATCH 3/5] ethtool: Introduce n-tuple filter
	programming support

>-----Original Message-----
>From: Ben Hutchings [mailto:bhutchings@...arflare.com]
>Sent: Monday, January 11, 2010 11:33 AM
>To: Kirsher, Jeffrey T
>Cc: davem@...emloft.net; netdev@...r.kernel.org; gospo@...hat.com;
>Waskiewicz Jr, Peter P; Luca Deri; Gasparakis, Joseph
>Subject: Re: [net-next-2.6 PATCH 3/5] ethtool: Introduce n-tuple filter
>programming support
>
>On Wed, 2010-01-06 at 20:49 -0800, Jeff Kirsher wrote:
>> From: PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>
>>
>> This patchset enables the ethtool layer to program n-tuple
>> filters to an underlying device.  The idea is to allow capable
>> hardware to have static rules applied that can assist steering
>> flows into appropriate queues.
>[...]
>> @@ -500,6 +529,8 @@ struct ethtool_ops {
>>  	int	(*set_rxnfc)(struct net_device *, struct ethtool_rxnfc *);
>>  	int     (*flash_device)(struct net_device *, struct ethtool_flash
>*);
>>  	int	(*reset)(struct net_device *, u32 *);
>> +	int	(*set_rx_ntuple)(struct net_device *, struct
>ethtool_rx_ntuple *);
>> +	int	(*get_rx_ntuple)(struct net_device *, struct
>ethtool_rx_ntuple *, void *);
>>  };
>>  #endif /* __KERNEL__ */
>>
>[...]
>
>It it really necessary to add new driver operations?  It seems to me
>that it would be preferable to extend {get,set}_rx_nfc() and have the
>ethtool common code convert between the ethtool_rxnfc and
>ethtool_rx_ntuple structures.  Does that seem possible?
>

It is possible, but I'm not sure if it's the right way to go.  The nfc routines are just flipping the various engines on in niu, where the ntuple routines are for passing full amounts of data through for different filters.  Also, I think keeping them separate makes niu programming cleaner, which can support both the nfc and ntuple modes.

Cheers,
-PJ
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html