netdev - Re: [RFC 7/9] snet: introduce snet_netlink.c and snet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2r5puipte.fsf@ssh.synack.fr>
Date:	Wed, 13 Jan 2010 05:36:29 +0100
From:	Samir Bellabes <sam@...ack.fr>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	linux-security-module@...r.kernel.org, jamal <hadi@...erus.ca>,
	Evgeniy Polyakov <zbr@...emap.net>,
	Neil Horman <nhorman@...driver.com>, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org
Subject: Re: [RFC 7/9] snet: introduce snet_netlink.c and snet_netlink.h

Patrick McHardy <kaber@...sh.net> writes:

> Samir Bellabes wrote:
>> +++ b/security/snet/include/snet_netlink.h
>> +
>> +struct snet_sock_half {
>> +	struct {
>> +		union {
>> +			__be32 ip;
>> +			struct in6_addr ip6;
>> +		};
>> +	} u3;
>> +	struct {
>> +		__be16 port;
>> +	} u;
>> +};
>> +
>> +struct snet_sock_info {
>> +	struct snet_sock_half src;
>> +	struct snet_sock_half dst;
>> +	int type;
>> +};
>
> How about using a struct sockaddr or encoding the values within
> netlink attributes? That would provide a bit more flexibility in
> case you want to support more protocols in the future.

indeed, I already move to the encoding of values independantly within
netlink attributes. This had to be done before, and it was in the
TODO, so now it's done. 

At first, I tried to use a attribute NLA_BINARY with all the datas
inside snet_sock_info, so it won't break the netlink protocol between
userspace and kernel, at each modification (adding/removing element
inside the structure) 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html