netdev - Re: [RFC 7/9] snet: introduce snet_netlink.c and snet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2d41eil09.fsf@ssh.synack.fr>
Date:	Wed, 13 Jan 2010 07:20:22 +0100
From:	Samir Bellabes <sam@...ack.fr>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	linux-security-module@...r.kernel.org, jamal <hadi@...erus.ca>,
	Evgeniy Polyakov <zbr@...emap.net>,
	Neil Horman <nhorman@...driver.com>, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org
Subject: Re: [RFC 7/9] snet: introduce snet_netlink.c and snet_netlink.h

Patrick McHardy <kaber@...sh.net> writes:

> Samir Bellabes wrote:
>> +static const struct nla_policy snet_genl_policy[SNET_A_MAX + 1]
>> +__read_mostly = {
>
> You don't need __read_mostly for const. If I recall correctly, it even
> causes an error with certain compiler or linker versions.

fixed, thanks Patrick

I didn't had errors with (fedora core 11):
gcc (GCC) 4.4.1 20090725 (Red Hat 4.4.1-2)
GNU ld version 2.19.51.0.2-17.fc11 20090204

nor (ubuntu 9.10):
gcc (Ubuntu 4.4.1-4ubuntu8) 4.4.1 
GNU ld (GNU Binutils for Ubuntu) 2.20 (2.20-0ubuntu2)

sam
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html