netdev - Re: [PATCH] [NET]: da.s_net not copied but assigned to itself in aarp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100114210001.GE20221@ghostprotocols.net>
Date:	Thu, 14 Jan 2010 19:00:01 -0200
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux Networking Development Mailing List 
	<netdev@...r.kernel.org>
Subject: Re: [PATCH] [NET]: da.s_net not copied but assigned to itself in
 aarp_rcv()

Em Thu, Jan 14, 2010 at 09:32:11PM +0100, Roel Kluin escreveu:
> da.s_net was not copied but assigned to itself.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>

Looks right, must be there for ages...

Acked-by: Arnaldo Carvalho de Melo <acme@...hat.com>

> ---
> diff --git a/net/appletalk/aarp.c b/net/appletalk/aarp.c
> index 9d4adfd..f2b3b56 100644
> --- a/net/appletalk/aarp.c
> +++ b/net/appletalk/aarp.c
> @@ -819,7 +819,7 @@ static int aarp_rcv(struct sk_buff *skb, struct net_device *dev,
>  				ma = &ifa->address;
>  			else { /* We need to make a copy of the entry. */
>  				da.s_node = sa.s_node;
> -				da.s_net = da.s_net;
> +				da.s_net = sa.s_net;
>  				ma = &da;
>  			}
>  
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html