netdev - Re: [PATCH] xprtsock.c: make bc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1263508956.2724.1.camel@localhost>
Date:	Thu, 14 Jan 2010 17:42:36 -0500
From:	Trond Myklebust <trond.myklebust@....uio.no>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	netdev@...r.kernel.org, linux-nfs@...r.kernel.org,
	bfields@...ldses.org, neilb@...e.de, davem@...emloft.net
Subject: Re: [PATCH] xprtsock.c: make bc_{malloc/free} static

On Thu, 2010-01-14 at 15:38 -0700, H Hartley Sweeten wrote: 
> xprtsock.c: make bc_{malloc/free} static
> 
> The server backchannel buf_alloc and buf_free methods should
> be static since they are not used outside this file.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: J. Bruce Fields <bfields@...ldses.org>
> Cc: Neil Brown <neilb@...e.de>
> Cc: Trond Myklebust <Trond.Myklebust@...app.com>
> Cc: David S. Miller <davem@...emloft.net>
> 
> ---
> 
> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
> index 3d739e5..721bafd 100644
> --- a/net/sunrpc/xprtsock.c
> +++ b/net/sunrpc/xprtsock.c
> @@ -2100,7 +2100,7 @@ static void xs_tcp_print_stats(struct rpc_xprt *xprt, struct seq_file *seq)
>   * we allocate pages instead doing a kmalloc like rpc_malloc is because we want
>   * to use the server side send routines.
>   */
> -void *bc_malloc(struct rpc_task *task, size_t size)
> +static void *bc_malloc(struct rpc_task *task, size_t size)
>  {
>  	struct page *page;
>  	struct rpc_buffer *buf;
> @@ -2120,7 +2120,7 @@ void *bc_malloc(struct rpc_task *task, size_t size)
>  /*
>   * Free the space allocated in the bc_alloc routine
>   */
> -void bc_free(void *buffer)
> +static void bc_free(void *buffer)
>  {
>  	struct rpc_buffer *buf;
>  

Thanks! I'll put this in the sunrpc-for-next branch.

Trond

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html