netdev - Re: [net-2.6 PATCH 1/2] ixgbe: Do not attempt to perform interrupts in netpoll when down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100113.171528.05861304.davem@davemloft.net>
Date:	Wed, 13 Jan 2010 17:15:28 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	alexander.h.duyck@...el.com, mallikarjuna.chilakala@...el.com
Subject: Re: [net-2.6 PATCH 1/2] ixgbe: Do not attempt to perform
 interrupts in netpoll when down

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Wed, 13 Jan 2010 03:49:13 -0800

> From: Alexander Duyck <alexander.h.duyck@...el.com>
> 
> This patch resolves issues seen when running netconsole and rebooting via
> reboot -f.  The issue was due to the fact that we were attempting to
> perform interrupt actions when the q_vectors and rings had already been
> freed via the ixgbe_shutdown routines.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
> Acked-by:  Mallikarjuna R Chilakala <mallikarjuna.chilakala@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied.

There has to be a better way to handle this, though.  In fact
I would expect the device to be detached early enough (and
thus ->netpoll() calls prevented) long before you would be
freeing up resources and shutting down the chip.

Why doesn't that happen?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html