netdev - Re: [PATCH net-next-2.6] can: Proper ctrlmode handling for CAN devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cabda6421001140653p296f4481oed1a1c731325961a@mail.gmail.com>
Date:	Thu, 14 Jan 2010 15:53:46 +0100
From:	christian pellegrin <chripell@...e.org>
To:	Wolfgang Grandegger <wg@...ndegger.com>
Cc:	socketcan-core@...ts.berlios.de, netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] can: Proper ctrlmode handling for CAN 
	devices

On Thu, Jan 14, 2010 at 3:36 PM, Wolfgang Grandegger <wg@...ndegger.com> wrote:
>
> I see. I really don't like the extra callback. Currently, it seems
> overkill to me. In principle, we could also do some checks in the device
> open function, if needed.
>

ack, I'll prepare a v2 patch soon.

>
> I found some links on that subject. Obviously, there is ENOTSUP and
> EOPNOTSUPP in the glibc, which are equal, but no ENOTSUPP. I tend to
> replace ENOTSUPP with EOPNOTSUPP, EINVAL or ENOSYS, what ever is more
> appropriate. Do you feel that EINVAL is more appropriate for the case above?
>

I'm perfectly ok with EOPNOTSUPP as you suggested.

-- 
Christian Pellegrin, see http://www.evolware.org/chri/
"Real Programmers don't play tennis, or any other sport which requires
you to change clothes. Mountain climbing is OK, and Real Programmers
wear their climbing boots to work in case a mountain should suddenly
spring up in the middle of the computer room."
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html