netdev - Re: ixgbe: [RFC] [PATCH] Fix return of invalid txq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100115.004456.15627093.davem@davemloft.net>
Date:	Fri, 15 Jan 2010 00:44:56 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	peter.p.waskiewicz.jr@...el.com
Cc:	krkumar2@...ibm.com, netdev@...r.kernel.org,
	jeffrey.t.kirsher@...el.com
Subject: Re: ixgbe: [RFC] [PATCH] Fix return of invalid txq

From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
Date: Thu, 14 Jan 2010 23:58:17 -0800

> I've been trying to find time to add something like igb has, with a
> tiny Tx lookup table that maps CPUs into a smaller set of Tx queues.

Why do you need "tables"?  Just modulo the it, with whatever
optimizations you can come up with.

Or do we not have enough data references in the TX path already?
:-/

I would suggest getting rid of the table in IGB too.

Either "tables" are a good idea (I think they definitely are not)
or they are not.  And whatever the decision is we should do it
consistently.  net/core/dev.c doesn't use tables, it does the
subtraction modulo thing like Krishna does.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html