netdev - Re: [RFC] [PATCH] Optimize TCP sendmsg in favour of fast devices?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100115.010450.64181969.davem@davemloft.net>
Date:	Fri, 15 Jan 2010 01:04:50 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	simon.kagstrom@...insight.net
Cc:	krkumar2@...ibm.com, ilpo.jarvinen@...sinki.fi,
	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [RFC] [PATCH] Optimize TCP sendmsg in favour of fast devices?

From: Simon Kagstrom <simon.kagstrom@...insight.net>
Date: Fri, 15 Jan 2010 10:00:11 +0100

> On Fri, 15 Jan 2010 00:52:24 -0800 (PST)
> David Miller <davem@...emloft.net> wrote:
> 
>> > The same thing goes for via-velocity.c, it's turned on via ethtool
>> > though (ethtool_op_set_sg).
>> 
>> Indeed, see my reply to Krishna's ethtool_op_set_sg() patch.
>> 
>> I think it's a cruddy way to do things, SG ought to be on by
>> default always unless it is defective.  And if it's defective
>> support should be removed entirely.
> 
> I kept it off by default since I didn't see any big improvement in my
> tests (negative in some, positive in some). But I suppose you're
> right though.

Well, it has to provide significantly better performance for
sendfile() (especially wrt. cpu utilization) because we avoid the copy
out of the page cache pages entirely.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html