lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20100116.005023.137878764.davem@davemloft.net> Date: Sat, 16 Jan 2010 00:50:23 -0800 (PST) From: David Miller <davem@...emloft.net> To: hartleys@...ionengravers.com Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, kuznet@....inr.ac.ru, pekkas@...core.fi, jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net Subject: Re: [PATCH] ipv4/ip_sockglue.c: copy msg_control optval from user to kernel space From: "H Hartley Sweeten" <hartleys@...ionengravers.com> Date: Sat, 16 Jan 2010 01:22:21 -0500 > On Fri 1/15/2010 8:30 PM, David Miller wrote: >> How did you test your change? > > Hmm... I saw the sparse warning and tried this to fix it. The code compiled > fine and the warning was gone. When I booted the resulting kernel I didn't > see any issues. I must not have went down this code path in my testing. I'm going to ask you a second time. What was your test case? How did you test the change? I don't think you tested your change at all besides seeing that gcc would accept the code and sparse stopped spitting out a warning. And you're vagueness about your testing methodology will only work to confirm my suspicions. I find it unlikely, at best, for you to have tested that code path, as 'msg' is an uninitilized stack variable at this point in the code, so 'msg->msg_control' is going to be a garbage pointer, and therefore copying to it would result in a crash. I don't even think you read and understood the code you are editing. I suspect you just wanted to kill the sparse warning somehow, you found a way that made the compiler and sparse eat it, and you simply ran with it. And that really upsets me. Fixing sparse warnings should not be a mindless exercise. You should understand the code you are changing. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists