lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100117003653.GA3073@del.dom.local> Date: Sun, 17 Jan 2010 01:36:53 +0100 From: Jarek Poplawski <jarkao2@...il.com> To: Michael Chan <mchan@...adcom.com> Cc: Eric Dumazet <eric.dumazet@...il.com>, David Miller <davem@...emloft.net>, "kaber@...sh.net" <kaber@...sh.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Jeff Kirsher <jeffrey.t.kirsher@...el.com>, Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com> Subject: Re: [PATCH v4] net: Introduce realloc_netdev_mq() On Sat, Jan 16, 2010 at 02:50:48PM -0800, Michael Chan wrote: > > On Fri, 2009-12-04 at 05:49 -0800, Jarek Poplawski wrote: > > On Fri, Dec 04, 2009 at 01:01:34PM +0000, Jarek Poplawski wrote: > > > Eric, if didn't miss something in the example you gave at the > > > beginning of this thread, it seems a change like below (not compiled) > > > should fix your problem (without even testing MSI exactly)? > > > > Bringing back an older thread. Are we still planning to use > realloc_netdev_mq()? I hope so, except it seems we lost Eric's interest in (t)his idea, and got Peter's kind opinion. > The problem with the patch below is that > dev->real_num_tx_queues can still be reduced during bnx2_open(). > I'm not sure I get your point, but there should be no problem with changing dev->real_num_tx_queues during ->open(). The main intention of realloc_netdev_mq() is to give drivers some official way to change dev->num_tx_queues until register_netdev() with the main aim: not to treat obviously non-mq chips as mq according to netif_is_multiqueue(). Additional gain is memory saved in the case fixed by the patch below (which btw. waits for some refinement/verification). > Is it possible to call realloc_netdev_mq() during ->open()? No, and no such intention, since there was kind of agreement it's not necessary and collides with preserving qdisc state (stats). But the discussion isn't closed... Thanks, Jarek P. > > > OOPS! Take 2...;-) > > > > Jarek P. > > --- > > > > drivers/net/bnx2.c | 5 +++++ > > 1 files changed, 5 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c > > index 4bfc808..c1ba2b1 100644 > > --- a/drivers/net/bnx2.c > > +++ b/drivers/net/bnx2.c > > @@ -8288,6 +8288,11 @@ bnx2_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) > > dev->features |= NETIF_F_TSO6; > > vlan_features_add(dev, NETIF_F_TSO6); > > } > > + > > + if (!((bp->flags & BNX2_FLAG_MSIX_CAP) || > > + (bp->flags & BNX2_FLAG_MSI_CAP)) || disable_msi) > > + realloc_netdev_mq(dev, 1); > > + > > if ((rc = register_netdev(dev))) { > > dev_err(&pdev->dev, "Cannot register net device\n"); > > goto error; > > > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists