lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100117092221.2fca789c@nehalam> Date: Sun, 17 Jan 2010 09:22:21 -0800 From: Stephen Hemminger <shemminger@...tta.com> To: Ben Hutchings <bhutchings@...arflare.com> Cc: Tom Herbert <therbert@...gle.com>, davem@...emloft.net, netdev@...r.kernel.org Subject: Re: [PATCH v5] rps: Receive Packet Steering On Sat, 16 Jan 2010 02:11:33 +0000 Ben Hutchings <bhutchings@...arflare.com> wrote: > On Thu, 2010-01-14 at 14:56 -0800, Stephen Hemminger wrote: > > On Thu, 14 Jan 2010 13:56:23 -0800 (PST) > > Tom Herbert <therbert@...gle.com> wrote: > [...] > > > The CPU masks is set on a per device basis in the sysfs variable > > > /sys/class/net/<device>/rps_cpus. This is a set of canonical bit maps for > > > each NAPI nstance of the device. For example: > > > > > > echo "0b 0b0 0b00 0b000" > /sys/class/net/eth0/rps_cpus > > > > Why not make a kobject out of cpus which would add subdirectory. > > This would keep interface consistent with the one value per file > > semantic of sysfs. > > Do you mean a kobject per NAPI context, each initially with a rps_cpus > attribute holding a CPU mask, or a kobject per CPU, each with an > attribute specifying which NAPI contexts it does work for? (Personally > I'd favour the first.) Yes, make NAPI real kobjects, linked to device. BUT make sure this also handles case of N to 1 mapping as well as 1 to N case. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists