netdev - Re: [PATCH 1/1] Constify struct sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B536FFF.9060509@gmail.com>
Date:	Sun, 17 Jan 2010 21:15:59 +0100
From:	Emese Revfy <re.emese@...il.com>
To:	Al Viro <viro@...IV.linux.org.uk>
CC:	linux-kernel@...r.kernel.org, teigland@...hat.com,
	Matt_Domsch@...l.com, maciej.sosnowski@...el.com,
	hjk@...utronix.de, Pekka Enberg <penberg@...helsinki.fi>,
	jens.axboe@...cle.com, shemminger@...tta.com,
	akpm@...ux-foundation.org, davem@...emloft.net,
	torvalds@...ux-foundation.org, netdev@...r.kernel.org,
	Greg KH <gregkh@...e.de>
Subject: Re: [PATCH 1/1] Constify struct sysfs_ops for v2.6.33-rc4

Al Viro wrote:
> On Sun, Jan 17, 2010 at 06:25:37PM +0000, Al Viro wrote:
>> On Sun, Jan 17, 2010 at 05:20:38PM +0100, Emese Revfy wrote:
>>
>>> Signed-off-by: Emese Revfy <re.emese@...il.com>
>>> Acked-by: David Teigland <teigland@...hat.com>
>>> Acked-by: Matt Domsch <Matt_Domsch@...l.com>
>>> Acked-by: Maciej Sosnowski <maciej.sosnowski@...el.com>
>>> Acked-by: Hans J. Koch <hjk@...utronix.de>
>>> Acked-by: Pekka Enberg <penberg@...helsinki.fi>
>>> Acked-by: Jens Axboe <jens.axboe@...cle.com>
>>> Acked-by: Stephen Hemminger <shemminger@...tta.com>
>> NACKed-by: Al Viro <viro@...iv.linux.org.uk>
>>
>> Same reason.
> 
> BTW, commit 9905a43b2d563e6f89e4c63c4278ada03f2ebb14
> Author: Emese Revfy <re.emese@...il.com>
> Date:   Mon Dec 14 00:58:57 2009 +0100
> 
>     backlight: Constify struct backlight_ops
> 
> is also crap; again, same reason.  Would you please get a clue and stop
> pushing that particular bullshit into the tree?

The backlight maintainer accepted that patch before the discussion
on field constification concluded.
I drew his attention to the discussion (http://lkml.org/lkml/2009/12/16/395)
but he still accepted the patch as is.
--
Emese
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html