netdev - Re: [PATCH 3/9] drivers/net: Eliminate useless code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1001180646460.12648@ask.diku.dk>
Date:	Mon, 18 Jan 2010 06:47:30 +0100 (CET)
From:	Julia Lawall <julia@...u.dk>
To:	David Miller <davem@...emloft.net>
Cc:	ron.mercer@...gic.com, linux-driver@...gic.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/9] drivers/net: Eliminate useless code

On Sun, 17 Jan 2010, David Miller wrote:

> From: Julia Lawall <julia@...u.dk>
> Date: Sat, 16 Jan 2010 16:57:56 +0100 (CET)
> 
> > The variable qdev is initialized twice to the same (side effect-free)
> > expression.  Drop one initialization.
> > 
> > A simplified version of the semantic match that finds this problem is:
> > (http://coccinelle.lip6.fr/)
> > 
> > // <smpl>
> > @forall@
> > idexpression *x;
> > identifier f!=ERR_PTR;
> > @@
> > 
> > x = f(...)
> > ... when != x
> > (
> > x = f(...,<+...x...+>,...)
> > |
> > * x = f(...)
> > )
> > // </smpl>
> > 
> > Signed-off-by: Julia Lawall <julia@...u.dk>
> 
> Something in your patch creation process is corrupting these
> patches.
> 
> > diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
> > index f922294..4ef0afb 100644
> > --- a/drivers/net/qla3xxx.c
> > +++ b/drivers/net/qla3xxx.c
> > @@ -4087,9 +4087,8 @@ static void __devexit ql3xxx_remove(struct pci_dev *pdev)
> >  	struct ql3_adapter *qdev = netdev_priv(ndev);
> >  
> >  	unregister_netdev(ndev);
> > -	qdev = netdev_priv(ndev);
> >  
> >  	ql_disable_interrupts(qdev);
> >  
> > --
> 
> That hunk header states that after the line is removed there should
> be 8 lines present in the hunk, but the patch only shows 7 such
> lines.
> 
> I suspect something is eating the final line of your patches.

Oops, sorry.  I will try again.  I'm surprised that checkpatch didn't 
complain.

julia
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html