[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100118195100.GB3157@del.dom.local>
Date: Mon, 18 Jan 2010 20:51:00 +0100
From: Jarek Poplawski <jarkao2@...il.com>
To: Hagen Paul Pfeifer <hagen@...u.net>
Cc: netdev@...r.kernel.org, kaber@...sh.net, davem@...emloft.net
Subject: Re: [PATCH 1/1] sched: add head drop fifo queue
On Mon, Jan 18, 2010 at 08:36:45PM +0100, Hagen Paul Pfeifer wrote:
> * Jarek Poplawski | 2010-01-18 20:25:17 [+0100]:
>
> >I don't think this is needed; qdisc_dequeue_head() updated it already.
>
> No, the bookkeeping stuff is done in the previous call layer. It is not really
> nice solved but to generalize this stuff adds unnecessary overhead.
Did you test it? IMHO "sch->q.qlen--" is done 2 times.
Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists