netdev - Re: ppp_generic.c severly whitespace damanged by 9c705260feea6ae329bc6b6d5f6d2ef0227eda0a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100119154455.GJ24305@caffeine.csclub.uwaterloo.ca>
Date:	Tue, 19 Jan 2010 10:44:55 -0500
From:	lsorense@...lub.uwaterloo.ca (Lennart Sorensen)
To:	David Miller <davem@...emloft.net>
Cc:	lsorense@...lub.uwaterloo.ca, linux-kernel@...r.kernel.org,
	gabriele.paoloni@...el.com, netdev@...r.kernel.org
Subject: Re: ppp_generic.c severly whitespace damanged by
	9c705260feea6ae329bc6b6d5f6d2ef0227eda0a

On Tue, Jan 19, 2010 at 02:13:01AM -0800, David Miller wrote:
> From: lsorense@...lub.uwaterloo.ca (Lennart Sorensen)
> Date: Mon, 18 Jan 2010 17:59:55 -0500
> 
> > I was just looking at ppp_generic, and noticed that it fairly recently
> > (as in the last year) got rather mangled with many spaces turned into tabs
> > in places they very much shouldn't have been.  I tracked it down to commit
> > 9c705260feea6ae329bc6b6d5f6d2ef0227eda0a (ppp: ppp_mp_explode() redesign).
> > 
> > I am amazed if that patch passed the patch checking script.  I have no
> > idea what kind of weird editor setting did this, but it has to have been a
> > weird editor setting or a very unfortunate search and replace gone wrong.
> > I only found it trying to apply a patch I was playing with and wondering
> > why it wouldn't apply.  Then I found there were tabs in the middle of
> > comments that used to be spaces.
> > 
> > Well here is a patch that should fix it up as far as I can tell.
> > 
> > Purely whitespace repair.  No actual code changes.
> > 
> > Signed-off-by: Len Sorensen <lsorense@...lub.uwaterloo.ca>
> 
> I'm probably responsible for not catching this sorry.
> 
> Applied to net-next-2.6, thanks.

Great.  I hope I got them all.  I couldn't find anymore searching though.

-- 
Len Sorensen
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html