netdev - RE: [net-next-2.6 PATCH 1/5] ixgbe: Allocate driver resources per NUMA node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F86E8680A7D9D74A99DC6345E35A692950231698@orsmsx503.amr.corp.intel.com>
Date:	Tue, 19 Jan 2010 11:34:51 -0800
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	Andi Kleen <andi@...stfloor.org>
CC:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>
Subject: RE: [net-next-2.6 PATCH 1/5] ixgbe: Allocate driver resources per
	NUMA node

>-----Original Message-----
>From: Andi Kleen [mailto:andi@...stfloor.org]
>Sent: Tuesday, January 19, 2010 11:34 AM
>To: Waskiewicz Jr, Peter P
>Cc: Andi Kleen; Kirsher, Jeffrey T; davem@...emloft.net;
>netdev@...r.kernel.org; gospo@...hat.com
>Subject: Re: [net-next-2.6 PATCH 1/5] ixgbe: Allocate driver resources
>per NUMA node
>
>> >The problem of doing this is that the node might be full or have
>> >no memory and k*alloc_node will fail then.
>> >
>> >So you would need a fallback to be reliable (we probably should have
>a
>> >generic utility function for this somewhere, but we don't currently)
>>
>> So you'd rather see us call kzalloc() if kzalloc_node() fails, instead
>of immediately failing out to err_out?
>
>Yes.
>
>After all it's only an optimization to place memory, it's not
>a functional requirement.
>
>-Andi
>

Makes sense.  I have the change in my local tree and will push new patches through Jeff shortly.

Thanks Andi,
-PJ
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html