netdev - Re: [PATCH net-next-2.6] IFix IPv6 GSO type checks in Intel ethernet drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100119.141438.266557246.davem@davemloft.net>
Date:	Tue, 19 Jan 2010 14:14:38 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jesse.brandeburg@...el.com
Cc:	sri@...ibm.com, herbert@...dor.apana.org.au,
	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] IFix IPv6 GSO type checks in Intel
 ethernet drivers

From: "Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Date: Tue, 19 Jan 2010 13:11:00 -0800 (Pacific Standard Time)

> 
> 
> On Tue, 19 Jan 2010, Sridhar Samudrala wrote:
> 
>> Found this problem when testing IPv6 from a KVM guest to a remote
>> host via e1000e device on the host.
>> The following patch fixes the check for IPv6 GSO packet in Intel
>> ethernet drivers to use skb_is_gso_v6(). SKB_GSO_DODGY is also set
>> when packets are forwarded from a guest.
>> 
>> Signed-off-by: Sridhar Samudrala <sri@...ibm.com
> 
> Looks fine, thanks!  The current code in net-next and 2.6.32 both have 
> exactly the same condition in skb_is_gso_v6, so I'm not sure that this 
> patch alone will fix any issues, FYI.  If this patch is part of another 
> set or dependent upon another for the actual change in behavior mentioned 
> in the comment, I think it should be noted or sent in a series.
> 
> Ack-ed by: Jesse Brandeburg <jesse.brandeburg@...el.com>

Just FYI, I'm assuming I'll get this via Jeff eventually.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html