netdev - Re: [PATCH net-next-2.6] IFix IPv6 GSO type checks in Intel ethernet drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100119223934.GA30140@gondor.apana.org.au>
Date:	Wed, 20 Jan 2010 11:39:34 +1300
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Cc:	Sridhar Samudrala <sri@...ibm.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next-2.6] IFix IPv6 GSO type checks in Intel
	ethernet drivers

On Tue, Jan 19, 2010 at 01:11:00PM -0800, Brandeburg, Jesse wrote:
>
> Looks fine, thanks!  The current code in net-next and 2.6.32 both have 
> exactly the same condition in skb_is_gso_v6, so I'm not sure that this 
> patch alone will fix any issues, FYI.  If this patch is part of another 
> set or dependent upon another for the actual change in behavior mentioned 
> in the comment, I think it should be noted or sent in a series.

skb_is_gso_v6 does an & test instead of == so the patch is definitely
not a noop.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html