netdev - Re: [PATCH]: net: Unexport napi_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100120065654.GA7826@tuxmaker.boeblingen.de.ibm.com>
Date:	Wed, 20 Jan 2010 07:56:54 +0100
From:	Blaschka <frank.blaschka@...ibm.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [PATCH]: net: Unexport napi_gro_flush().

On Tue, Jan 19, 2010 at 02:12:55PM -0800, David Miller wrote:
> 
> Nothing outside of net/core/dev.c uses it.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
>  include/linux/netdevice.h |    1 -
>  net/core/dev.c            |    3 +--
>  2 files changed, 1 insertions(+), 3 deletions(-)
>

Hi Dave,

I have a qeth patch which uses napi_gro_flush (not posted yet).
There is following idea:

The inbound processing of the qeth driver is already in bottomhalf
(qdio input tasklet) so we can switch from netif_rx to
netif_receive_skb. This allows us to exploit gro code for the
layer 3 driver. I would introduce a dummy napi_struct and call
napi_gro_flush when the inbound tasklet ends.

Should I post the patch for review?

Thanks,
  Frank
 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index a3fccc8..468a11d 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1527,7 +1527,6 @@ extern int		netif_rx(struct sk_buff *skb);
>  extern int		netif_rx_ni(struct sk_buff *skb);
>  #define HAVE_NETIF_RECEIVE_SKB 1
>  extern int		netif_receive_skb(struct sk_buff *skb);
> -extern void		napi_gro_flush(struct napi_struct *napi);
>  extern gro_result_t	dev_gro_receive(struct napi_struct *napi,
>  					struct sk_buff *skb);
>  extern gro_result_t	napi_skb_finish(gro_result_t ret, struct sk_buff *skb);
> diff --git a/net/core/dev.c b/net/core/dev.c
> index a008f69..5747b9e 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -2582,7 +2582,7 @@ out:
>  	return netif_receive_skb(skb);
>  }
> 
> -void napi_gro_flush(struct napi_struct *napi)
> +static void napi_gro_flush(struct napi_struct *napi)
>  {
>  	struct sk_buff *skb, *next;
> 
> @@ -2595,7 +2595,6 @@ void napi_gro_flush(struct napi_struct *napi)
>  	napi->gro_count = 0;
>  	napi->gro_list = NULL;
>  }
> -EXPORT_SYMBOL(napi_gro_flush);
> 
>  enum gro_result dev_gro_receive(struct napi_struct *napi, struct sk_buff *skb)
>  {
> -- 
> 1.6.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html