netdev - Re: [PATCH 01/11] fs_enet: Add support for MPC512x to fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B573732.3030000@freescale.com>
Date:	Wed, 20 Jan 2010 11:02:42 -0600
From:	Scott Wood <scottwood@...escale.com>
To:	Anatolij Gustschin <agust@...x.de>
CC:	linuxppc-dev@...abs.org, wd@...x.de,
	John Rigby <jrigby@...escale.com>, netdev@...r.kernel.org,
	dzu@...x.de, Piotr Ziecik <kosmo@...ihalf.com>
Subject: Re: [PATCH 01/11] fs_enet: Add support for MPC512x to fs_enet driver

Anatolij Gustschin wrote:
> Scott Wood <scottwood@...escale.com> wrote:
>> You can put a data pointer in the of_platform match struct, instead of 
>> re-checking the compatible.
> 
> .data pointer in 'fs_enet_mdio_fec_match' is already used for
> mpc5xxx_get_bus_frequency(). Setting .data to some sort of FEC ID in
> match struct for "fsl,pq1-fec-mdio" would be confusing to.

You could point .data to a struct if there are multiple things.

-Scott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html